Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the short document.fonts.forEach preload polyfill in inlineCss mode #65

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Don't use the short document.fonts.forEach preload polyfill in inlineCss mode #65

merged 2 commits into from
Nov 2, 2019

Conversation

papandreou
Copy link
Collaborator

It's too sensitive to bundlers, so let's just eat the extra bytes: https://gitter.im/assetgraph/assetgraph?at=5dba0800ef84ab3786c862e3

@papandreou papandreou self-assigned this Oct 31, 2019
@papandreou papandreou requested a review from Munter October 31, 2019 22:42
@coveralls
Copy link

coveralls commented Oct 31, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 199

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 89.115%
Files with Coverage Reduction New Missed Lines %
lib/HeadlessBrowser.js 2 91.43%
Totals Coverage Status
Change from base Build 193: -0.2%
Covered Lines: 1902
Relevant Lines: 2038
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 199

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 89.115%
Files with Coverage Reduction New Missed Lines %
lib/HeadlessBrowser.js 2 91.43%
Totals Coverage Status
Change from base Build 193: -0.2%
Covered Lines: 1902
Relevant Lines: 2038
💛 - Coveralls

@Munter Munter mentioned this pull request Nov 1, 2019
Closed
@Munter Munter merged commit 305bc4b into master Nov 2, 2019
@Munter Munter deleted the feature/alwaysUseLongPreloadPolyfill branch November 2, 2019 08:23
@Munter
Copy link
Owner

Munter commented Nov 2, 2019

Released in /~https://github.com/Munter/subfont/releases/tag/v4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Awaiting requested review from Munter

Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter