Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test Node.js 8, 10 and 11 #46

Merged
merged 1 commit into from
Nov 29, 2018
Merged

ci: test Node.js 8, 10 and 11 #46

merged 1 commit into from
Nov 29, 2018

Conversation

DanielRuf
Copy link
Contributor

Node.js 9 has reached its EOL and we should check the current LTS 8 and 10 and current stable (11) - to fail early.

@coveralls
Copy link

coveralls commented Nov 26, 2018

Pull Request Test Coverage Report for Build 55

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.744%

Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 75
Relevant Lines: 101

💛 - Coveralls

@papandreou
Copy link
Collaborator

Looks like the HTTP mocking library also has trouble with node.js 11.2.0. Let's track that here: moll/node-mitm#55

I'm pretty sure that subfont itself works fine with node 11, but it would be really nice to not have to assume that :)

@DanielRuf
Copy link
Contributor Author

I'm pretty sure that subfont itself works fine with node 11, but it would be really nice to not have to assume that :)

Exactly. Thanks for creating and tracking the issue.

@papandreou
Copy link
Collaborator

Got it fixed now and published new versions of the underlying libraries.

Copy link
Collaborator

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@papandreou papandreou merged commit 54cfc7f into Munter:master Nov 29, 2018
@papandreou
Copy link
Collaborator

@DanielRuf, thanks for taking the initiative :)

@DanielRuf DanielRuf deleted the ci/test-nodejs-8-10-11 branch November 30, 2018 05:40
@DanielRuf
Copy link
Contributor Author

Thank you too for creating and maintaining subfont and the great collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants