Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @gustavnikolaj/async-main-wrap #44

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Aug 18, 2018

Gets rid of the arbitrary division of labor between lib/cli.js and lib/subfont.js and allows testing the command line options (instead of an unexposed programmatic API) without executing the binary in the test suite -- including the ability to mock out the network.

Also implement --dryrun and --silent.

CC: @gustavnikolaj

@papandreou papandreou requested a review from Munter August 18, 2018 13:38
@coveralls
Copy link

coveralls commented Aug 18, 2018

Pull Request Test Coverage Report for Build 53

  • 75 of 101 (74.26%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.2%) to 64.744%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/main.js 75 101 74.26%
Totals Coverage Status
Change from base Build 50: -7.2%
Covered Lines: 75
Relevant Lines: 101

💛 - Coveralls

@papandreou
Copy link
Collaborator Author

The drop in coverage % must be due to the removal of well-tested boilerplate code.

@papandreou papandreou force-pushed the feature/async-main-wrap branch from 760aa38 to 90cf9fb Compare August 18, 2018 13:55
@papandreou
Copy link
Collaborator Author

@Munter, any thoughts?

@gustavnikolaj
Copy link

There's a new version 3.0.0 that is just some neater output in error cases by default. :-)

@papandreou
Copy link
Collaborator Author

@gustavnikolaj, cool! I updated to that now.

@papandreou papandreou force-pushed the feature/async-main-wrap branch from e1629cd to 49c66ff Compare September 17, 2018 11:22
Copy link
Owner

@Munter Munter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can do this. Feels a bit ugly that all the conversion of arguments into cleanly applying options are now in the same file though. I'd prefer if we can keep the args to options conversion separated

@papandreou
Copy link
Collaborator Author

Cool, we can think about cutting that differently. As long as we get to make tests for the tool as a whole I’m happy :)

Implement --dryrun and --silent
@papandreou papandreou force-pushed the feature/async-main-wrap branch from 49c66ff to 31b9c07 Compare October 21, 2018 19:16
@papandreou
Copy link
Collaborator Author

As long as main.js isn't more lines than it is I actually think it's fine to have it all in one file. I'll merge for now, then we can see where it takes us :)

@papandreou papandreou merged commit 41a6715 into master Oct 21, 2018
@papandreou papandreou deleted the feature/async-main-wrap branch October 21, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants