Support subfont --formats foo,bar and fix weirdness with --formats consuming further non-option arguments #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was kinda surprised that
subfont --format woff,woff2
didn't work. Turns out yargs doesn't support that even though the option is declared asarray
: yargs/yargs#846Also, the
array
type is weird, so I found thatsubfont --formats woff2 path/to/page.html
fails because yargs tries to consumepath/to/page.html
as another format 🤪This PR fixes both issues by switching to
string
and coercing the result into an array.