Respect silent:true wrt. the console output #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of silent only controlling whether logEvents gets used Also, don't break if no console object gets handed in.
papandreou
force-pushed
the
fix/silentMode
branch
from
8b4772a to
f3b1eb1
Compare
Pull Request Test Coverage Report for Build 547
💛 - Coveralls |
|
Hopefully uncontroversial, will merge and release. |
|
Released in 5.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
silentonly controlling whetherlogEventsgets used.Also, don't break if no console object gets handed in.
I encountered this while writing up #122 (comment)