Use browserslist to configure which font formats to supply subsets and fallbacks in, and whether to add the JS-based preload polyfill #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 535
💛 - Coveralls |
papandreou
force-pushed
the
feature/browserslist
branch
from
ed45a7d to
0e1e6fb
Compare
papandreou
changed the title
papandreou
force-pushed
the
feature/browserslist
branch
from
0e1e6fb to
2bf7cf4
Compare
Munter
reviewed
Jul 28, 2020
lib/parseCommandLineOptions.js
Outdated
| type: 'array', | ||
| choices: ['woff2', 'woff', 'truetype'], | ||
| }) | ||
| .options('js-preload', { |
There was a problem hiding this comment.
I'm not sure we should expose this option. I'd rather promote usage of browserslist project configuration to have the tool just do the right thing
There was a problem hiding this comment.
Hmm, yeah, I agree. I've taken it out in dccddcf
| formats = ['woff2']; | ||
| if ( | ||
| _.intersection( | ||
| browsersList('supports woff, not supports woff2'), |
There was a problem hiding this comment.
I haven't seen this interface before. That's pretty awesome!
There was a problem hiding this comment.
Yeah, it's pretty nifty. A shame that we have to use lodash to combine it with the user's query though.
Co-authored-by: Peter Müller <munter@fumle.dk>
|
@Munter, good to go in? |
|
Yeah. Let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
The current set of default browsers happens to result in
woff+woff2and the JS preload polyfill being selected atm., which is luckily the same as our current--formatsdefault 🎉TODO: