Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also report the number of code points used on each page when subsetPerPage is false #114

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

papandreou
Copy link
Collaborator

Fixes #42

@papandreou papandreou requested a review from Munter July 15, 2020 16:11
@papandreou papandreou self-assigned this Jul 15, 2020
@papandreou papandreou force-pushed the feature/reportCodepointsPerPage branch from e36781c to 46701a6 Compare July 17, 2020 13:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 472

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 89.609%

Totals Coverage Status
Change from base Build 466: 0.008%
Covered Lines: 1031
Relevant Lines: 1102

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jul 17, 2020

Pull Request Test Coverage Report for Build 472

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 89.609%

Totals Coverage Status
Change from base Build 466: 0.008%
Covered Lines: 1031
Relevant Lines: 1102

💛 - Coveralls

@Munter Munter merged commit 7096bca into master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slightly misleading stats when building multiple pages
3 participants