Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14, #15 Bug fixes, telemetry removing #16

Merged
merged 5 commits into from
Dec 9, 2021
Merged

#14, #15 Bug fixes, telemetry removing #16

merged 5 commits into from
Dec 9, 2021

Conversation

MrRefactoring
Copy link
Owner

No description provided.

@MrRefactoring MrRefactoring changed the title Develop Fixes Dec 9, 2021
@MrRefactoring MrRefactoring changed the title Fixes Bug fixes (#14, #15). Telemetry removing Dec 9, 2021
@MrRefactoring MrRefactoring changed the title Bug fixes (#14, #15). Telemetry removing #14, #15 Bug fixes, telemetry removing Dec 9, 2021
This was linked to issues Dec 9, 2021
@MrRefactoring MrRefactoring merged commit 21217b9 into master Dec 9, 2021
@MrRefactoring MrRefactoring deleted the develop branch December 9, 2021 12:12
@emulienfou
Copy link
Contributor

Hi @MrRefactoring thanks for taking care of this issue.
However, just tested your latest changes and it seems there is an encoding issue.

I have the next code: getSpaces({ spaceKey: ['KEY1', KEY2', 'KEY3'] }) but the generated url is https://example.atlassian.net/wiki/rest/api/space?spaceKey=KEY1,%26spaceKey%3DKEY2,%26spaceKey%3DKEY3.
This url includes & character encoded and also include a , comma, no idea why!

Correct should be: https://example.atlassian.net/wiki/rest/api/space?spaceKey=KEY1&spaceKey=KEY2&spaceKey=KEY3

Encoding the parameters special characters like & or = seems to not work properly since the JSON response returns "self": "https://example.atlassian.net/wiki/rest/api/space?spaceKey=KEY1&spaceKey=KEY2&spaceKey=KEY3=" and return all unfiltered results.

Hope this helps!

@MrRefactoring
Copy link
Owner Author

Oh sh*t, I missed it. Will try to fix it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachments download Cannot get spaces, spaceKey values issue
2 participants