-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display mailto links properly in Snaps link warning #30000
Merged
Merged
+42
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
previously approved these changes
Jan 30, 2025
Mrtenz
reviewed
Jan 30, 2025
Mrtenz
previously approved these changes
Jan 30, 2025
GuillaumeRx
previously approved these changes
Jan 30, 2025
d0bfe66
GuillaumeRx
approved these changes
Jan 30, 2025
Mrtenz
approved these changes
Jan 30, 2025
Builds ready [d0bfe66]
Page Load Metrics (1898 ± 79 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.12.0
Issue or pull request that will be included in release 12.12.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a formatting issue when displaying mailto links in the
SnapLinkWarning
. This was broken due to parsing themailto:
link in the same way as HTTPS and assumptions made about the output of that parsing.Related issues
Fixes: #29977
Manual testing steps
See the attached ticket
Screenshots/Recordings
Before
See the attached ticket
After