Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display mailto links properly in Snaps link warning #30000

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 30, 2025

Description

Fixes a formatting issue when displaying mailto links in the SnapLinkWarning. This was broken due to parsing the mailto: link in the same way as HTTPS and assumptions made about the output of that parsing.

Open in GitHub Codespaces

Related issues

Fixes: #29977

Manual testing steps

See the attached ticket

Screenshots/Recordings

Before

See the attached ticket

After

image

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 30, 2025 10:41
@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 30, 2025
GuillaumeRx
GuillaumeRx previously approved these changes Jan 30, 2025
Mrtenz
Mrtenz previously approved these changes Jan 30, 2025
GuillaumeRx
GuillaumeRx previously approved these changes Jan 30, 2025
@FrederikBolding FrederikBolding dismissed stale reviews from GuillaumeRx and Mrtenz via d0bfe66 January 30, 2025 11:05
@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d0bfe66]
Page Load Metrics (1898 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30422271580629302
domContentLoaded16192147185313665
load16822297189816579
domInteractive24108492412
backgroundConnect9252455426
firstReactRender16180573818
getState5103242914
initialActions01000
loadScripts11281655136513263
setupStore866232210
uiStartup189630872226295141
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 310 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 0be8d4a Jan 30, 2025
70 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snap-link-warning-email branch January 30, 2025 12:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Email id is not displayed in the dialog
4 participants