fix: bug when requested accounts/chainIds do not match wallet state

[adonesky1]

Description

Fix bug when requested accounts/chainIds do not match wallet state

Manual testing steps

See videos below:

await window.ethereum.request({
 "method": "wallet_requestPermissions",
 "params": [
  {
    
    "eth_accounts": {
        "caveats": [
            {
                "type": "restrictReturnedAccounts",
                "value": []
            }
        ]
    },
    "endowment:permitted-chains": {
        "caveats": [
            {
                "type": "restrictNetworkSwitching",
                "value": ['0xbf04'] // any chainId not in the wallet
            }
        ]
    }
  }
],
});

await window.ethereum.request({
 "method": "wallet_requestPermissions",
 "params": [
  {
    
    "eth_accounts": {
        "caveats": [
            {
                "type": "restrictReturnedAccounts",
                "value": ["0x549f7D54F0a7ef67707c55dc51123586a2c6654e"] // any address not in the wallet
            }
        ]
    },
    "endowment:permitted-chains": {
        "caveats": [
            {
                "type": "restrictNetworkSwitching",
                "value": []
            }
        ]
    }
  }
],
});

Screenshots/Recordings

Before

Screen.Recording.2025-01-29.at.3.46.00.PM.mov

Screen.Recording.2025-01-29.at.3.47.16.PM.mov

After

Screen.Recording.2025-01-29.at.3.52.24.PM.mov

Screen.Recording.2025-01-29.at.3.53.30.PM.mov

Screen.Recording.2025-01-29.at.3.28.12.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [dbce84a]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1489 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	299	2077	1442	326	157
		domContentLoaded	1286	2022	1477	193	93
		load	1294	2074	1489	199	96
		domInteractive	22	80	37	19	9
		backgroundConnect	7	50	17	14	7
		firstReactRender	14	79	37	26	13
		getState	4	40	7	8	4
		initialActions	0	0	0	0	0
		loadScripts	916	1562	1072	173	83
		setupStore	7	85	17	21	10
		uiStartup	1460	2700	1704	278	134

[ffmcgee725]

LGTM 🚀

[metamaskbot]

Builds ready [3eb6ade]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1650 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1456	2024	1649	178	85
		domContentLoaded	1418	2016	1636	175	84
		load	1458	2028	1650	178	85
		domInteractive	23	76	35	13	6
		backgroundConnect	8	63	19	15	7
		firstReactRender	15	93	50	26	12
		getState	4	51	11	13	6
		initialActions	0	1	0	0	0
		loadScripts	1013	1553	1200	150	72
		setupStore	7	66	15	17	8
		uiStartup	1617	2581	1915	258	124

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 274 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [595ce45]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1804 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	271	2040	1571	549	263
		domContentLoaded	1552	1987	1775	116	56
		load	1564	2002	1804	121	58
		domInteractive	24	69	38	13	6
		backgroundConnect	9	95	28	23	11
		firstReactRender	16	98	42	27	13
		getState	4	90	19	23	11
		initialActions	0	1	0	0	0
		loadScripts	1110	1519	1323	112	54
		setupStore	8	62	21	20	10
		uiStartup	1792	2595	2068	184	88

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 274 Bytes (0.00%)
• common: 0 Bytes (0.00%)