feat: Use gasLimitNoBuffer on network fee estimation

[OGPoyraz]

Description

While estimating gas for the transaction we add 50% gas limit buffer. With this PR we want to show network fee without gas limit buffer using gasLimitNoBuffer property on transactionMeta.

Related issues

Fixes: /~https://github.com/MetaMask/MetaMask-planning/issues/3773

Manual testing steps

N/A

Screenshots/Recordings

In the recording you will see that gasLimitNoBuffer used over txParams.gas. Please see that txParams.gas is greater than gasLimitNoBuffer. This calculation leads lower value in the UI.

Screen.Recording.2025-01-08.at.13.12.30.mov

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [d96d86b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1734 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	307	1913	1610	420	202
		domContentLoaded	1508	1886	1705	97	46
		load	1519	1903	1734	98	47
		domInteractive	27	94	35	15	7
		backgroundConnect	7	83	31	22	10
		firstReactRender	16	73	39	23	11
		getState	5	60	16	16	8
		initialActions	0	0	0	0	0
		loadScripts	1114	1427	1277	95	46
		setupStore	6	57	13	15	7
		uiStartup	1799	2369	2002	131	63

[metamaskbot]

Builds ready [44608df]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1756 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	261	2038	1597	455	219
		domContentLoaded	1537	1958	1725	127	61
		load	1574	1988	1756	131	63
		domInteractive	25	134	47	29	14
		backgroundConnect	7	147	31	32	16
		firstReactRender	17	107	51	31	15
		getState	5	96	27	28	14
		initialActions	0	1	0	0	0
		loadScripts	1099	1506	1291	117	56
		setupStore	6	54	11	10	5
		uiStartup	1813	2756	2118	290	139

[matthewwalsh0]

Relevant to my comment in the core PR, we wouldn't need the fallback here if we always populated gasLimitNoBuffer.

[OGPoyraz]

Done

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/transaction-controller@43.0.0 🔁 npm/@metamask/transaction-controller@42.1.0	None	0	2.18 MB	metamaskbot

View full report↗︎

[metamaskbot]

Builds ready [60b0af0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1793 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	251	2232	1643	470	226
		domContentLoaded	1381	2226	1773	203	98
		load	1398	2232	1793	205	99
		domInteractive	23	103	43	20	10
		backgroundConnect	5	59	18	17	8
		firstReactRender	17	95	39	27	13
		getState	5	52	19	18	9
		initialActions	0	1	0	0	0
		loadScripts	968	1739	1309	178	86
		setupStore	6	58	17	18	9
		uiStartup	1638	2515	2070	237	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 84 Bytes (0.00%)
• common: 118 Bytes (0.00%)