Test scenarios #20785

tmashuang · 2023-09-07T17:55:02Z

Explanation

Test scenarios for eth sign, personal sign, sign typed data, sign in with ethereum, encrypt & decrypt message, and connecting and disconnecting from dapp

Closes #18941
Closes #18940
Closes #18929

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-09-07T17:55:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-09-07T18:23:07Z

Builds ready [010b296]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1718 ± 142 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	357	149	53	25
		domContentLoaded	1414	2510	1716	292	140
		load	1415	2538	1718	296	142
		domInteractive	1414	2510	1716	292	140

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-09-07T18:23:26Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fd84e8b) 68.54% compared to head (10f2d23) 68.54%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20785   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1029     1029           
  Lines        41013    41013           
  Branches     10963    10963           
========================================
  Hits         28109    28109           
  Misses       12904    12904

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-07T22:32:02Z

Builds ready [1559c62]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1657 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	118	190	143	19	9
		domContentLoaded	1478	1886	1657	107	51
		load	1478	1886	1657	107	51
		domInteractive	1478	1886	1657	107	51

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-09-08T17:42:51Z

Builds ready [55d3e63]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1539 ± 30 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	147	124	12	6
		domContentLoaded	1437	1668	1539	62	30
		load	1437	1669	1539	62	30
		domInteractive	1437	1668	1539	62	30

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-09-11T19:37:47Z

Builds ready [76e7e89]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1535 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	157	124	13	6
		domContentLoaded	1385	1960	1535	151	72
		load	1385	1960	1535	151	72
		domInteractive	1385	1960	1535	151	72

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

benjisclowder · 2023-10-11T15:34:33Z

Hi @tmashuang , could you please switch the Goerli network recommendation to Sepolia since the former will be deprecated?

metamaskbot · 2023-10-11T15:56:35Z

Builds ready [ca5b004]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (703 ± 360 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	133	97	11	5
		domContentLoaded	67	130	88	14	7
		load	82	1909	703	750	360
		domInteractive	67	130	88	14	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/scenarios/11. sign/eth sign.csv

test/scenarios/12. decrypt/encrypt and decrypt.csv

chloeYue · 2023-10-17T10:08:49Z

Hi @tmashuang , could you please switch the Goerli network recommendation to Sepolia since the former will be deprecated?

Done. Thanks !

metamaskbot · 2023-10-17T11:00:56Z

Builds ready [4f09e38]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (666 ± 406 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	194	128	28	13
		domContentLoaded	73	185	112	31	15
		load	85	2318	666	845	406
		domInteractive	73	185	112	31	15

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-10-18T20:27:00Z

Builds ready [10f2d23]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (973 ± 419 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	186	96	23	11
		domContentLoaded	63	250	93	38	18
		load	74	3140	973	872	419
		domInteractive	63	250	93	38	18

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

tmashuang added 6 commits September 7, 2023 10:48

Eth sign test scenario

cc21bea

Personal sign test scenario

2b4eab7

Sign in with ethereum test scenario

57e801c

Sign typed data test scenario

0eb8752

Encyrt and decrypt message test scenario

0f4b898

connecting and disconnecting from a dapp test scenario

010b296

tmashuang requested a review from a team as a code owner September 7, 2023 17:55

tmashuang added team-extension-client team-extension-platform labels Sep 7, 2023

gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 7, 2023

Merge branch 'develop' into test-scenarios

1559c62

Merge branch 'develop' into test-scenarios

55d3e63

tmashuang added 2 commits September 8, 2023 15:33

Merge branch 'develop' into test-scenarios

cc98e75

Merge branch 'develop' into test-scenarios

76e7e89

Merge branch 'develop' into test-scenarios

ca5b004

brad-decker previously approved these changes Oct 11, 2023

View reviewed changes

PeterYinusa reviewed Oct 11, 2023

View reviewed changes

test/scenarios/11. sign/eth sign.csv Outdated Show resolved Hide resolved

PeterYinusa reviewed Oct 11, 2023

View reviewed changes

test/scenarios/12. decrypt/encrypt and decrypt.csv Outdated Show resolved Hide resolved

improvement

2dd0aee

chloeYue dismissed brad-decker’s stale review via 2dd0aee October 17, 2023 10:08

improvement

4f09e38

Merge branch 'develop' into test-scenarios

e747491

chloeYue added the area-documentation Issues relating to documentation, in the codebase and off. label Oct 18, 2023

Merge branch 'develop' into test-scenarios

10f2d23

chloeYue self-assigned this Oct 19, 2023

chloeYue requested review from PeterYinusa and brad-decker October 20, 2023 11:58

PeterYinusa approved these changes Oct 26, 2023

View reviewed changes

chloeYue approved these changes Oct 26, 2023

View reviewed changes

chloeYue merged commit 4a08daf into develop Oct 26, 2023

chloeYue deleted the test-scenarios branch October 26, 2023 13:32

github-actions bot locked and limited conversation to collaborators Oct 26, 2023

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2023

metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test scenarios #20785

Test scenarios #20785

tmashuang commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023

metamaskbot commented Sep 7, 2023

codecov bot commented Sep 7, 2023 •

edited

Loading

metamaskbot commented Sep 7, 2023

metamaskbot commented Sep 8, 2023

metamaskbot commented Sep 11, 2023

benjisclowder commented Oct 11, 2023

metamaskbot commented Oct 11, 2023

chloeYue commented Oct 17, 2023

metamaskbot commented Oct 17, 2023

metamaskbot commented Oct 18, 2023

Test scenarios #20785

Test scenarios #20785

Conversation

tmashuang commented Sep 7, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 7, 2023

metamaskbot commented Sep 7, 2023

codecov bot commented Sep 7, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 7, 2023

metamaskbot commented Sep 8, 2023

metamaskbot commented Sep 11, 2023

benjisclowder commented Oct 11, 2023

metamaskbot commented Oct 11, 2023

chloeYue commented Oct 17, 2023

metamaskbot commented Oct 17, 2023

metamaskbot commented Oct 18, 2023

tmashuang commented Sep 7, 2023 •

edited

Loading

codecov bot commented Sep 7, 2023 •

edited

Loading