Replacing deprecated components and fixing prop errors #19745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -63,7 +63,6 @@ export default function FormField({ | |||
| <Text | |||
| tag="label" | |||
| htmlFor={id} | |||
| html | |||
There was a problem hiding this comment.
Fixes incorrect prop being passed to Text component
Comment on lines
+218
to
+248
| /** | ||
| * 2px | ||
| */ | ||
| XS = 'xs', | ||
| /** | ||
| * 4px | ||
| */ | ||
| SM = 'sm', | ||
| /** | ||
| * 6px | ||
| */ | ||
| MD = 'md', | ||
| /** | ||
| * 8px | ||
| */ | ||
| LG = 'lg', | ||
| /** | ||
| * 12px | ||
| */ | ||
| XL = 'xl', | ||
| /** | ||
| * 0 | ||
| */ | ||
| none = 'none', | ||
| /** | ||
| * 9999px | ||
| */ | ||
| pill = 'pill', | ||
| /** | ||
| * 50% | ||
| */ |
There was a problem hiding this comment.
Not part of this issue but very helpful to see the pixel value when hovering over the size abstraction
|
|
||
| @include screen-sm-min { | ||
| margin-inline-end: 43px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Removing unused CSS
Comment on lines
-4
to
-5
| import Box from '../../../components/ui/box'; | ||
| import Button from '../../../components/ui/button'; |
There was a problem hiding this comment.
Replacing deprecated components
| </Box> | ||
| </div> | ||
| </Box> | ||
| ); |
There was a problem hiding this comment.
Reduces a lot of HTML nesting
georgewrmarshall
added
the
team-design-system
Builds ready [01acf6c]
Page Load Metrics (1705 ± 57 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19745 +/- ##
========================================
Coverage 69.83% 69.83%
========================================
Files 980 980
Lines 36886 36886
Branches 9890 9890
========================================
Hits 25757 25757
Misses 11129 11129
|
darkwing
approved these changes
Jun 26, 2023
NidhiKJha
approved these changes
Jun 26, 2023
vthomas13
approved these changes
Jun 26, 2023
metamaskbot
added
the
release-10.34.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Some prop type errors were introduced with some of the replacing of deprecated components. This PR replaces some deprecated components, removes the incorrect props and fixes some props being pass down to the html element in form-filed.js
Screenshots/Screencaps
Before
before.mov
After
after.mov
Manual Testing Steps
SecureYourWalletPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.