Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated linea image for token and badge #19717

Merged
merged 2 commits into from
Jun 26, 2023
Merged

updated linea image for token and badge #19717

merged 2 commits into from
Jun 26, 2023

Conversation

NidhiKJha
Copy link
Member

This PR is to update the Linea logo for the avatar and badge when on the Linea network. In this solution, we have added a hardcoded string check to ensure that the correct image is displayed for the avatar token and badge.

We introduced the new Linea logo with this PR. But the tokenImage is undefined when we tried to access it for the badge on the home screen. The ideal solution will be to have the image be directly included there.

Screenshots

Before

Screenshot 2023-06-22 at 3 09 39 PM

After

Screenshot 2023-06-22 at 3 06 10 PM

Manual Testing Steps

  • Go to Linea network
  • Check the linea logo is updated for the avatar badge and avatar token same as what is used in the network picker in header

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Jun 22, 2023
@NidhiKJha NidhiKJha requested a review from a team as a code owner June 22, 2023 09:41
@NidhiKJha NidhiKJha requested a review from micaelae June 22, 2023 09:41
@metamaskbot
Copy link
Collaborator

Builds ready [00a5c6b]
Page Load Metrics (1755 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1143161464421
domContentLoaded14712007173412962
load14712008175512861
domInteractive14712007173412962
Bundle size diffs
  • background: 0 bytes
  • ui: 106 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #19717 (0eb14a2) into develop (ed702af) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop   #19717      +/-   ##
===========================================
- Coverage    70.79%   70.79%   -0.00%     
===========================================
  Files          988      988              
  Lines        38366    38369       +3     
  Branches     10042    10045       +3     
===========================================
+ Hits         27161    27163       +2     
- Misses       11205    11206       +1     
Impacted Files Coverage Δ
...ents/multichain/token-list-item/token-list-item.js 95.24% <75.00%> (-4.76%) ⬇️

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a more elegant way to do this:

  • shared/constants/network.ts
  • NATIVE_CURRENCY_TOKEN_IMAGE_MAP

Adding a constant for the Linea image should be a bit cleaner.

@NidhiKJha NidhiKJha requested a review from darkwing June 23, 2023 12:07
@metamaskbot
Copy link
Collaborator

Builds ready [0eb14a2]
Page Load Metrics (1653 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1041861272110
domContentLoaded1501180316308139
load1502182016538943
domInteractive1501180316308139
Bundle size diffs
  • background: 0 bytes
  • ui: 236 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha merged commit e9423be into develop Jun 26, 2023
@NidhiKJha NidhiKJha deleted the fix-19689 branch June 26, 2023 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Linea token icon
5 participants