-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated linea image for token and badge #19717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
needs-ux-ds-review
labels
Jun 22, 2023
Builds ready [00a5c6b]
Page Load Metrics (1755 ± 61 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19717 +/- ##
===========================================
- Coverage 70.79% 70.79% -0.00%
===========================================
Files 988 988
Lines 38366 38369 +3
Branches 10042 10045 +3
===========================================
+ Hits 27161 27163 +2
- Misses 11205 11206 +1
|
darkwing
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a more elegant way to do this:
shared/constants/network.ts
NATIVE_CURRENCY_TOKEN_IMAGE_MAP
Adding a constant for the Linea image should be a bit cleaner.
Builds ready [0eb14a2]
Page Load Metrics (1653 ± 43 ms)
Bundle size diffs
|
darkwing
approved these changes
Jun 23, 2023
vthomas13
approved these changes
Jun 26, 2023
metamaskbot
added
the
release-10.34.0
Issue or pull request that will be included in release 10.34.0
label
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-10.34.0
Issue or pull request that will be included in release 10.34.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the Linea logo for the avatar and badge when on the Linea network. In this solution, we have added a hardcoded string check to ensure that the correct image is displayed for the avatar token and badge.
We introduced the new Linea logo with this PR. But the tokenImage is undefined when we tried to access it for the badge on the home screen. The ideal solution will be to have the image be directly included there.
Screenshots
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.