-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Multichain: fixed padding for edit screen #19707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
needs-ux-ds-review
labels
Jun 21, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [32a30ce]
Page Load Metrics (1792 ± 83 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop MetaMask/metamask-extension#19707 +/- ##
========================================
Coverage 70.79% 70.79%
========================================
Files 988 988
Lines 38366 38366
Branches 10042 10042
========================================
Hits 27161 27161
Misses 11205 11205
|
darkwing
approved these changes
Jun 26, 2023
pedronfigueiredo
approved these changes
Jun 26, 2023
metamaskbot
added
the
release-10.34.0
Issue or pull request that will be included in release 10.34.0
label
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-10.34.0
Issue or pull request that will be included in release 10.34.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove the extra margin between header and content from all the screens and just adding it to the send edit and swap screen.
Screenshots/Screencaps
Screen.Recording.2023-06-21.at.9.33.42.PM.mov
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.