Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Multichain: fixed padding for edit screen #19707

Merged
merged 5 commits into from
Jun 26, 2023
Merged

UX Multichain: fixed padding for edit screen #19707

merged 5 commits into from
Jun 26, 2023

Conversation

NidhiKJha
Copy link
Member

This PR is to remove the extra margin between header and content from all the screens and just adding it to the send edit and swap screen.

  • Fixes MetaMask/MetaMask-planning#850

Screenshots/Screencaps

Screen.Recording.2023-06-21.at.9.33.42.PM.mov

Manual Testing Steps

  • Go to send and swap screen
  • Check the content and header has gap of 16px

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha marked this pull request as ready for review June 21, 2023 16:05
@NidhiKJha NidhiKJha requested a review from a team as a code owner June 21, 2023 16:05
@NidhiKJha NidhiKJha added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Jun 21, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [32a30ce]
Page Load Metrics (1792 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint991771432110
domContentLoaded15692038177216077
load15692196179217283
domInteractive15692038177216077
Bundle size diffs
  • background: 0 bytes
  • ui: 6 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #19707 (32a30ce) into develop (ed702af) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   MetaMask/metamask-extension#19707   +/-   ##
========================================
  Coverage    70.79%   70.79%           
========================================
  Files          988      988           
  Lines        38366    38366           
  Branches     10042    10042           
========================================
  Hits         27161    27161           
  Misses       11205    11205           
Impacted Files Coverage Δ
ui/pages/routes/routes.component.js 48.92% <ø> (-0.36%) ⬇️
ui/components/multichain/app-header/app-header.js 50.44% <100.00%> (+0.44%) ⬆️

@NidhiKJha NidhiKJha merged commit eb506a5 into develop Jun 26, 2023
@NidhiKJha NidhiKJha deleted the fix-19690-b branch June 26, 2023 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants