-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Snow with LavaMoat scuttling protection #17969
Conversation
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are unpublished packages?Package version was not found on the registry. It may exist on a different registry and need to be configured to pull from that registry. Packages can be removed from the registry by manually un-publishing, a security issue removal, or may simply never have been published to the registry. Reliance on these packages will cause problem when they are not found. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Codecov Report
@@ Coverage Diff @@
## develop #17969 +/- ##
===========================================
- Coverage 70.80% 70.79% -0.01%
===========================================
Files 988 988
Lines 38366 38366
Branches 10042 10042
===========================================
- Hits 27162 27160 -2
- Misses 11204 11206 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ nvm, LGTM! 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR follows up on LavaMoat/LavaMoat#462 which allows exporting the scuttling security feature to an outside scuttler (as an experimental feature⚠️ ).
This in fact allows us in MetaMask to perform scuttling not only to the top main realm, but to all potential child realms using Snow.
In other words, if an attacker wants to access
alert
but can't because thealert
property is scuttled, the attacker could have opened an iframe (aka new realm) and extract thealert
function from the global object of that iframe.With this PR, Snow will automatically apply the scuttling mechanizm to all new potential child realms, including the iframe described in the example, thus leaving the attacker unable to get a hold of an
alert
function instance.The
alert
example is merely a demonstration of course, but scuttling all windows recursively brings an important security benefit to MetaMask (will be elaborated in the future).