-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add key literals to driver #10854
Merged
Merged
add key literals to driver #10854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
abstract-key-into-driver
branch
2 times, most recently
from
April 8, 2021 22:00
108a021
to
fcee942
Compare
Builds ready [fcee942]
Page Load Metrics (585 ± 50 ms)
|
Gudahtt
reviewed
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Apart from the conflicts. I can re-review after those are resolved.
brad-decker
force-pushed
the
abstract-key-into-driver
branch
from
April 12, 2021 14:52
fcee942
to
1a9f286
Compare
brad-decker
force-pushed
the
abstract-key-into-driver
branch
from
April 12, 2021 15:13
1a9f286
to
467121c
Compare
Gudahtt
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [467121c]
Page Load Metrics (634 ± 57 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the abstraction around sending keystrokes/values to input fields. The API aims to match playwright's implementation to allow a more straightforward migration in the near future. There are a few pieces:
.press
driver.fill
API to the driver that matches playwright'sfill
method. Fill differs fromsendKeys
in that it replaces the current value instead of adding to it.driver.press
API to the driver that matches playwright'spress
method. Playwright's implementation differs in that it expects key names like 'Enter' while selenium's expects unicode encoded key values.fill
andpress
methods.This PR includes the refactor to use these.