Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring threebox.spec.js to use fixtures #10849

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Refactoring threebox.spec.js to use fixtures #10849

merged 3 commits into from
Apr 8, 2021

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Apr 8, 2021 •
edited
Loading

Fixes: #10848

Explanation:

  • Moved the file to test/e2e/tests
  • Updated threebox.spec.js to use fixtures.
  • Updated run-all.sh to use the new test file.
  • Updated the test/e2e/mock-3box/server.js to be called from the test instead of running it as a script.

@NiranjanaBinoy NiranjanaBinoy requested a review from Gudahtt April 8, 2021 01:41
@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review April 8, 2021 21:30
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 8, 2021 21:30
@metamaskbot
Copy link
Collaborator

Builds ready [fd5077e]
Page Load Metrics (584 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint479462126
domContentLoaded32883858213263
load32983958413263
domInteractive32883758213263

Gudahtt
Gudahtt approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NiranjanaBinoy NiranjanaBinoy merged commit 8df7a71 into develop Apr 8, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the e2e-fixtures-threebox branch April 8, 2021 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor threebox.spec.js to follow pattern in metamask-extension/test/e2e/tests
3 participants
@NiranjanaBinoy @metamaskbot @Gudahtt