add abstraction for waitForSelector #10844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
commented
Apr 7, 2021
| // Providing a text prop, and optionally a tag or css prop, will use | ||
| // xpath to look for an element with the tag that has matching text. | ||
| if (locator.css) { | ||
| // When providing css prop we use cssToXPath to build a xpath string |
There was a problem hiding this comment.
A majority of our usage of until.elementMatchesText was using a css selector then waiting until the returned element had matching text. Building an xpath combining CSS selection and text selection more closely mimics Playwright's API (page.waitForSelector('.hello >> text="hi"'). XPath IS slower than CSS selectors, BUT in the case of searching for text, it is not possible without XPath. Combining them into XPath is likely faster than issuing two statements looking for both a CSS selector AND then waiting for text to match.
In the end, though, this entire method (buildLocator) will go away and we will use the much more powerful and expressive playwright selector API.
Builds ready [a3c1468]
Page Load Metrics (645 ± 34 ms)
|
brad-decker
requested review from
shanejonas and
Gudahtt
and removed request for
shanejonas
Gudahtt
reviewed
Apr 8, 2021
brad-decker
force-pushed
the
until-abstraction
branch
from
a3c1468 to
71870f4
Compare
Builds ready [71870f4]
Page Load Metrics (586 ± 43 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an abstraction for waitForSelector, a method that exists in the playwright API. This abstraction aims to eventually become a paper-thin abstraction over the playwright version. In the meantime
untilis used behind the scenes to mimick the behavior.Included is a refactor of
metamask-ui.spec.jswhich served as a robustness check for the utility.