-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring signature-request.spec.js to use fixtures #10820
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [c60a53a]
Page Load Metrics (553 ± 60 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we can remove more from the end, but I can approve after that.
I think the last section was intended to verify the signature, but it doesn't actually do that unfortunately.
Builds ready [d591290]
Page Load Metrics (611 ± 43 ms)
|
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Builds ready [33ef58c]
Page Load Metrics (558 ± 62 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes: #10806
Explanation:
test/e2e/tests
signature-request.spec.js
to use fixtures.run-all.sh
to use the new test file.signature-request.spec.js
file