Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring signature-request.spec.js to use fixtures #10820

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Apr 4, 2021

Fixes: #10806

Explanation:

  • Moved the file to test/e2e/tests
  • Updated signature-request.spec.js to use fixtures.
  • Updated run-all.sh to use the new test file.
  • Deleted the old signature-request.spec.js file

@NiranjanaBinoy NiranjanaBinoy requested review from Gudahtt and danjm April 4, 2021 20:12
@NiranjanaBinoy NiranjanaBinoy self-assigned this Apr 4, 2021
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner April 4, 2021 20:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [c60a53a]
Page Load Metrics (553 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded34873355212460
load35073455312460
domInteractive34873355212460

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can remove more from the end, but I can approve after that.

I think the last section was intended to verify the signature, but it doesn't actually do that unfortunately.

test/e2e/tests/signature-request.spec.js Outdated Show resolved Hide resolved
test/e2e/tests/signature-request.spec.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [d591290]
Page Load Metrics (611 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45715794
domContentLoaded3837606108943
load3857616118943
domInteractive3837606108943

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@metamaskbot
Copy link
Collaborator

Builds ready [33ef58c]
Page Load Metrics (558 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45806084
domContentLoaded37387655613062
load37587755812962
domInteractive37287555613062

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NiranjanaBinoy NiranjanaBinoy merged commit d1d7622 into develop Apr 7, 2021
@NiranjanaBinoy NiranjanaBinoy deleted the e2e-fixtures-signature-request branch April 7, 2021 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor signature-request.spec.js to follow pattern in metamask-extension/test/e2e/tests
3 participants