Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for locators into driver abstraction #10802

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

brad-decker
Copy link
Contributor

supersedes #10801

Adds support for inline locators in driver element matcher methods, instead of using Selenium's By abstraction. In the interim, they ALSO accept the latter. Additional PRs will be set up to convert usages to remove the usage of By

@metamaskbot
Copy link
Collaborator

Builds ready [05c3797]
Page Load Metrics (542 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43675284
domContentLoaded3246385418641
load3256405428641
domInteractive3246385418541

@brad-decker brad-decker marked this pull request as ready for review April 1, 2021 23:04
@brad-decker brad-decker requested a review from a team as a code owner April 1, 2021 23:04
@brad-decker brad-decker requested a review from ryanml April 1, 2021 23:04
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 097439e into develop Apr 2, 2021
@brad-decker brad-decker deleted the add-selector-support-to-driver branch April 2, 2021 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants