Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build - fix bug in empty file copying #10780

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Build - fix bug in empty file copying #10780

merged 1 commit into from
Mar 31, 2021

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Mar 31, 2021

whoops, so sorry

the source/pattern/dest copy does not quite work the way i expected 😬

@kumavis kumavis requested a review from a team as a code owner March 31, 2021 07:14
@kumavis kumavis requested a review from brad-decker March 31, 2021 07:14
@kumavis
Copy link
Member Author

kumavis commented Mar 31, 2021

develop resulted in a file called chromereload.jsempty.js in the prod build
this gave me an idea for a snapshot of the build output, as a sanity check
may implement in another PR

EtDu
EtDu approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ggwp

@metamaskbot
Copy link
Collaborator

Builds ready [b574e92]
Page Load Metrics (608 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint479059115
domContentLoaded3557146078742
load3577216088742
domInteractive3557136068742

ryanml
ryanml approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kumavis kumavis merged commit 0040b66 into develop Mar 31, 2021
@kumavis kumavis deleted the build-sys-6 branch March 31, 2021 08:13
@kumavis
Copy link
Member Author

kumavis commented Mar 31, 2021

fyi @Gudahtt

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EtDu EtDu EtDu approved these changes

@ryanml ryanml ryanml approved these changes

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumavis @metamaskbot @ryanml @EtDu