Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Zealand Dollar to currency options #10746

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

ScreamingHawk
Copy link
Contributor

Fixes: -

Explanation:
I was annoyed that I wasn't able to view my wallet balance in my own currency. Had a quick dig through the code and found that it's a simple fix to include it.
Double checked against the API that the currency is listed here: /~https://github.com/MetaMask/controllers/blob/develop/src/apis/crypto-compare.ts

If you are happy to accept this I can push the same change to the mobile repo as well.

Manual testing steps:

  • Navigate to Settings
  • Select Currency Conversion drop down
  • Select New Zealand Dollar from the drop down
  • Confirm wallet value is accurate

@ScreamingHawk ScreamingHawk requested a review from a team as a code owner March 27, 2021 11:51
@ScreamingHawk ScreamingHawk requested a review from ryanml March 27, 2021 11:51
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ScreamingHawk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for the contribution @ScreamingHawk

@brad-decker brad-decker merged commit 8b3d96b into MetaMask:develop Mar 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
@ScreamingHawk ScreamingHawk deleted the nzd-currency branch May 24, 2021 04:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants