Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth-block-tracker@5.0.1 #10737

Merged
merged 1 commit into from
Mar 26, 2021
Merged

eth-block-tracker@5.0.1 #10737

merged 1 commit into from
Mar 26, 2021

Conversation

rekmarks
Copy link
Member

New major version of eth-block-tracker. Exports changed, and our uses have been updated.

@rekmarks rekmarks requested a review from a team as a code owner March 26, 2021 15:43
@rekmarks rekmarks requested a review from danjm March 26, 2021 15:43
@metamaskbot
Copy link
Collaborator

Builds ready [832bfd5]
Page Load Metrics (614 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43745794
domContentLoaded37980661310148
load38180861410148
domInteractive37980661210148

danjm
danjm approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks merged commit 6d1add7 into develop Mar 26, 2021
@rekmarks rekmarks deleted the eth-block-tracker@5.0.1 branch March 26, 2021 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@shanejonas shanejonas shanejonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @shanejonas @danjm