Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 10706 - Prevent autocomplete from add token input #10700

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Fix 10706 - Prevent autocomplete from add token input #10700

merged 1 commit into from
Mar 25, 2021

Conversation

darkwing
Copy link
Contributor

Prevents autocomplete text from displaying in the Add Token input:

AddTokenAutocomplete

@darkwing darkwing requested a review from a team as a code owner March 23, 2021 18:53
@darkwing darkwing requested a review from shanejonas March 23, 2021 18:53
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ryanml
ryanml reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me! is there an issue that this should be tied to though?

@darkwing darkwing changed the title Prevent autocomplete from add token input Fix 10706 - Prevent autocomplete from add token input Mar 24, 2021
@darkwing
Copy link
Contributor Author

Created issue, added to PR title.

ryanml
ryanml approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@darkwing darkwing merged commit c14919c into MetaMask:develop Mar 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@shanejonas shanejonas Awaiting requested review from shanejonas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkwing @ryanml