Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps - remove "remotedev-server" #10687

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Mar 22, 2021

removes remotedev-server as dep

if you use it as part of your workflow, please add it globally yarn global add remotedev-server

@kumavis kumavis requested a review from a team as a code owner March 22, 2021 13:17
@kumavis kumavis requested a review from NiranjanaBinoy March 22, 2021 13:17
@metamaskbot
Copy link
Collaborator

Builds ready [cdbad3b]
Page Load Metrics (640 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45685373
domContentLoaded5997306383014
load6037316403014
domInteractive5997296383014

@rekmarks rekmarks requested a review from Gudahtt March 22, 2021 15:57
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three packages are no longer used, and should be removed from the allow-scripts config:

  • sqlite3
  • ejs
  • sc-uws

Any packages that are no longer in the dependency tree have been
removed from the `allow-scripts` config.
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the three extraneous entries myself, since I already had it checked out locally to test this out.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [d6876e0]
Page Load Metrics (637 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44675863
domContentLoaded5937146353216
load5937156373216
domInteractive5927136353215

@Gudahtt
Copy link
Member

Gudahtt commented Mar 22, 2021

Correction: ejs is still present in the dependency tree, but only ejs@3, which doesn't have any install scripts. ejs@2 does have install scripts, and it has been removed in this PR.

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ff86465 into develop Mar 22, 2021
@Gudahtt Gudahtt deleted the deps-remove-remotedev-server branch March 22, 2021 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
@kumavis
Copy link
Member Author

kumavis commented Mar 23, 2021

❤️ ❤️ ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants