Adding default properties to NetworkForm #10682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10681
In
NetworkForm
, the initial is state is given default values of component properties. When navigating to the "Add a network form" from the network dropdown specifically, those initial properties areundefined
. In the case of adding a network, those fields should default to''
. This simply adds a defaultProps block ensuring that the values areprop || ''
as they should not beundefined
when set as the initial value of a text input field.Manual testing steps:
Defined in issue
Reviewer's manual testing note - a simple regression test for adding and managing custom networks should be performed from both the network dropdown and the settings tab.