Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TextField to receive min and max attributes #10656

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Mar 16, 2021

When an input has a type of number, up and down arrows appear for the users to click. Since we have known min and max values for token precision, we should use them.

@darkwing darkwing requested a review from a team as a code owner March 16, 2021 01:53
@darkwing darkwing requested a review from danjm March 16, 2021 01:53
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit da90674 into MetaMask:develop Mar 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants