Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDeps(base): allow eslint-plugin-jsdoc ^43.0.7 #319

Merged
merged 1 commit into from
Sep 14, 2023
Merged

peerDeps(base): allow eslint-plugin-jsdoc ^43.0.7 #319

merged 1 commit into from
Sep 14, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 1, 2023 •
edited
Loading

Was previously part of #288 but broken out pending merge of #290. This proceeds with enabling use of eslint-plugin-promise v43, which will allow users smoother migration experiences.

#288 (comment)

Sample woes undone by this:

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 1, 2023
@legobeat legobeat force-pushed the jsdoc-nodejs-compat branch from a03737d to 936a07f Compare September 1, 2023 06:20
@legobeat legobeat marked this pull request as ready for review September 1, 2023 06:49
@legobeat legobeat requested a review from a team as a code owner September 1, 2023 06:49
@legobeat legobeat requested review from Gudahtt and mcmire September 1, 2023 06:49
@legobeat legobeat force-pushed the jsdoc-nodejs-compat branch from 936a07f to ab79de6 Compare September 1, 2023 08:42
@legobeat legobeat requested review from Mrtenz and a team September 11, 2023 14:10
@legobeat legobeat added the help wanted Extra attention is needed label Sep 11, 2023
@legobeat legobeat mentioned this pull request Sep 13, 2023
Merged
2 tasks
Gudahtt
Gudahtt approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 7c43a31 into MetaMask:main Sep 14, 2023
@legobeat legobeat mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Gudahtt