BREAKING: Update ESLint from v7 to v8 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
changed the title
ESLint has been updated to v8 in all packages. This lets us use the latest version of ESLint in our other packages without getting `peerDependency` mismatch warnings. The main change to be aware of is that four new recommended rules have been added: * `no-loss-of-precision` [1] * `no-nonoctal-decimal-escape` [2] * `no-unsafe-optional-chaining` [3] * `no-useless-backreference` [4] Our validation script was broken in this update because ESLint stopped exporting their recommended configuration. `patch-package` was added so that we could patch ESLint to export this configuration. This was taken from #221, thanks @mcmire for this idea. [1]: https://eslint.org/docs/latest/rules/no-loss-of-precision [2]: https://eslint.org/docs/latest/rules/no-nonoctal-decimal-escape [3]: https://eslint.org/docs/latest/rules/no-unsafe-optional-chaining [4]: https://eslint.org/docs/latest/rules/no-useless-backreference
mcmire
approved these changes
Aug 15, 2022
| @@ -30,14 +30,14 @@ | |||
| "@metamask/eslint-config": "^9.0.0", | |||
| "@typescript-eslint/eslint-plugin": "^5.33.0", | |||
| "@typescript-eslint/parser": "^5.33.0", | |||
| "eslint": "^7.23.0", | |||
| "eslint": "^8.21.0", | |||
| "typescript": "^4.0.7" | |||
There was a problem hiding this comment.
We should bump this eventually along with the other typescript packages, but not necessary now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint has been updated to v8 in all packages. This lets us use the latest version of ESLint in our other packages without getting
peerDependencymismatch warnings.The main change to be aware of is that four new recommended rules have been added:
no-loss-of-precisionno-nonoctal-decimal-escapeno-unsafe-optional-chainingno-useless-backreferenceOur validation script was broken in this update because ESLint stopped exporting their recommended configuration.
patch-packagewas added so that we could patch ESLint to export this configuration. This was taken from #221, thanks @mcmire for this idea.