-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable id-denylist and id-length in base config #200
Conversation
d75f63a
to
b6530a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... this seems like it would have a lot of violations 🤔 Has this been tested on the extension or controllers repo?
96ce427
to
bb8e3a2
Compare
3851d69
to
e11ca49
Compare
e11ca49
to
8ed79e1
Compare
@Gudahtt a couple of tests:
|
I think this is a good idea. Too bad we can't configure ESLint to autofix these for us. |
73be5cb
to
946ccc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this. This rule can be disabled in the extension until the violations can be gone through.
I am in favour of this as well. I can approve once v10 has been published. Better to keep this for the v11 release to avoid making the v10 update too challenging. |
This modifies the base config to forbid specific identifier names (e.g.
err
,cb
) and variable and function names shorter than two characters (with some exceptions).