Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add account support check in validator #4816

Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Oct 17, 2024

Explanation

Mirrors the wallet_createSession handler
in how eth account support is checked/asserted. Opted to do this rather than modify assertScopeSupported because the bucketScopes helper also relies on assertScopedSupported but doesn't care about accounts (which is why eth accounts are checked outside of assertScopeSupported in the wallet_createSession handler currently)

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi jiexi requested a review from a team as a code owner October 17, 2024 22:18
jiexi and others added 2 commits October 17, 2024 15:38
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
jiexi and others added 2 commits October 17, 2024 15:40
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiexi jiexi merged commit dae4f73 into caip-multichain Oct 17, 2024
116 checks passed
@jiexi jiexi deleted the jl/caip-multichain/permission-validator-accounts branch October 17, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants