-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add account support check in validator #4816
Merged
jiexi
merged 5 commits into
caip-multichain
from
jl/caip-multichain/permission-validator-accounts
Oct 17, 2024
Merged
add account support check in validator #4816
jiexi
merged 5 commits into
caip-multichain
from
jl/caip-multichain/permission-validator-accounts
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
reviewed
Oct 17, 2024
adonesky1
reviewed
Oct 17, 2024
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
adonesky1
reviewed
Oct 17, 2024
adonesky1
reviewed
Oct 17, 2024
Co-authored-by: Alex Donesky <adonesky@gmail.com>
adonesky1
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Mirrors the wallet_createSession handler
in how eth account support is checked/asserted. Opted to do this rather than modify
assertScopeSupported
because thebucketScopes
helper also relies onassertScopedSupported
but doesn't care about accounts (which is why eth accounts are checked outside of assertScopeSupported in the wallet_createSession handler currently)References
Changelog
@metamask/package-a
@metamask/package-b
Checklist