-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactoring context menus #836
Merged
sgriff96
merged 11 commits into
Memmy-App:main
from
flx-sta:feature/refactoring-context-menus
Jul 23, 2023
Merged
Feature/refactoring context menus #836
sgriff96
merged 11 commits into
Memmy-App:main
from
flx-sta:feature/refactoring-context-menus
Jul 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into feature/refactoring-context-menus
sgriff96
requested changes
Jul 23, 2023
sgriff96
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Creator Checklist
Ensure you've checked the following before submitting your PR:
Summary
Unified approach to Context menus via 2 wrapper components.
They could probably be more generalised (maybe with a hook?) But my brain wasn't gonna figure it out today...
It all looks the same except some missing translations (at least in german and english).
Add some
destructive = true
where it seemed to make senseScreenshots
It all looks the same except some missing translations (at least in german and english)


Test Plan
some from the top of my head