Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactoring context menus #836

Merged
merged 11 commits into from
Jul 23, 2023

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 23, 2023

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

Unified approach to Context menus via 2 wrapper components.
They could probably be more generalised (maybe with a hook?) But my brain wasn't gonna figure it out today...

It all looks the same except some missing translations (at least in german and english).
Add some destructive = true where it seemed to make sense

Screenshots

It all looks the same except some missing translations (at least in german and english)
image
image

Test Plan

Basically check out all the context menus in the app and see if they still look and feel the same.

some from the top of my head

  • All/Local/Subscription picker top middle
  • top right sort
  • top right community
  • top right comment
  • long press comment
  • long press profile
  • general settings
  • apperance settings

@flx-sta flx-sta marked this pull request as ready for review July 23, 2023 19:18
@flx-sta flx-sta requested a review from sgriff96 July 23, 2023 20:11
Copy link
Collaborator

@sgriff96 sgriff96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgriff96 sgriff96 merged commit 7305409 into Memmy-App:main Jul 23, 2023
@flx-sta flx-sta deleted the feature/refactoring-context-menus branch July 23, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants