Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2nd miscellaneous bug #1124

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix 2nd miscellaneous bug #1124

merged 2 commits into from
Sep 12, 2024

Conversation

BentiGorlich
Copy link
Member

When creating a page we didn't look whether this object existed before, while we do it with note objects. So just copy over the code that checks whether a note already exists and we should be golden

When creating a page we didn't look whether this object existed before, while we do it with note objects. So just copy over the code that checks whether a note already exists and we should be golden
@BentiGorlich BentiGorlich added bug Something isn't working activitypub ActivityPub related issues backend Backend related issues and pull requests labels Sep 12, 2024
@BentiGorlich BentiGorlich added this to the v1.7.2 milestone Sep 12, 2024
@BentiGorlich BentiGorlich self-assigned this Sep 12, 2024
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup make sense do first (get) check, before doing a create.

@BentiGorlich BentiGorlich enabled auto-merge (squash) September 12, 2024 18:45
@BentiGorlich BentiGorlich merged commit 822ed46 into main Sep 12, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/melroy-misc-2nd branch September 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants