-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New improvements and test cases #27
Merged
MattKeeley
merged 36 commits into
main
from
26-spoofing-not-possible-without-spf-or-dmarc-record
Aug 12, 2024
Merged
New improvements and test cases #27
MattKeeley
merged 36 commits into
main
from
26-spoofing-not-possible-without-spf-or-dmarc-record
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKeeley
deleted the
26-spoofing-not-possible-without-spf-or-dmarc-record
branch
August 12, 2024 22:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Request Description
This merge request addresses several key improvements and enhancements:
Resolved False Negatives in Issue Spoofing not possible without SPF or DMARC record. #26:
Program Modularization:
process_domain
function to be more modular, enabling its use as a library in other tools.BIMI Record Resolver Cleanup:
Test Case Enhancements:
New Logic for DMARC and SPF Records:
Syntax Validation Class:
SyntaxValidator
class to ensure SPF and DMARC records conform to RFC syntax requirements before evaluation.Threading Support:
-t
option for threading, allowing for more efficient processing of multiple records.