Refactor build-states-to-change #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acron0
reviewed
Apr 9, 2018
src/clj/witan/send/send.clj
Outdated
| (vector cy ay :NONSEND (states/state need setting))) | ||
| (defn generate-transition-key [{:keys [transition-type cy ay need setting move-state]}] | ||
| (when (not= move-state (states/state need setting)) | ||
| (cond (= transition-type "joiners") |
There was a problem hiding this comment.
case might be slightly nicer here
src/clj/witan/send/send.clj
Outdated
| (generate-transition-key year age need (second setting)))) | ||
| state-pairs)) valid-needs)) ages)) years))))) | ||
| (defn build-states-to-change [input valid-needs valid-settings ages years transition-type] | ||
| (let [to-maps (->> input |
There was a problem hiding this comment.
thread-last not really required
src/clj/witan/send/send.clj
Outdated
| :setting-2)) | ||
| (map #(vector (:setting-1 %)) to-maps) | ||
| (map #(vector (:setting-1 %) (:setting-2 %)) to-maps))] | ||
| (->> (mapcat (fn [year] |
There was a problem hiding this comment.
This is easy to follow but unlikely to be very performant. Perhaps there's another way?
There was a problem hiding this comment.
happy to take suggestions, I thought before that it didn't look very nice, but I do need to map over each of these seqs of things...
src/clj/witan/send/send.clj
Outdated
| (vector (generate-transition-key (merge keys {:setting (first setting-to-change)})) | ||
| (generate-transition-key (merge keys {:setting (second setting-to-change)})))))) | ||
| settings-to-change)) valid-settings)) valid-needs)) ages)) years) | ||
| vec |
There was a problem hiding this comment.
I don't think this vec is necesary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow modify transitions to apply to any kind of transition (joiner, mover or leaver)