Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore OAuth certificate errors when insecure is set #234

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Ignore OAuth certificate errors when insecure is set #234

merged 1 commit into from
Aug 22, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 22, 2023

Fixes #195

@orgads orgads mentioned this pull request Aug 22, 2023
Closed
@orgads orgads changed the title Ignore certificate errors when insecure is enabled Ignore OAuth certificate errors when insecure is set Aug 22, 2023
@DRuggeri
Copy link
Member

Thanks, this is a nice and easy one to include, @orgads . An added benefit is that it also reuses other httpClient values set such as timeout/etc!

@DRuggeri DRuggeri merged commit 0db7c53 into Mastercard:master Aug 22, 2023
@orgads orgads deleted the insecure-cert branch August 23, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificate signed by unknown authority
2 participants
@orgads @DRuggeri