Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply home offsets to probing and Z Safe Homing #19423

Conversation

InsanityAutomation
Copy link
Contributor

Apply home offsets where previously overlooked to allow for position changes following toolhead changes. Critical for machines such as the Lulzbot tool system as well as others in development.

@InsanityAutomation InsanityAutomation force-pushed the ApplyHomeOffsetsConsistently branch from 50f9fc4 to 4d72284 Compare September 19, 2020 15:09
@thinkyhead
Copy link
Member

So… This just needs a careful re-examination to take account of the M206 offsets in isolation without including the G92 workspace offsets. That should do the trick and get the correct positioning regardless of the current workspace.

@InsanityAutomation InsanityAutomation force-pushed the ApplyHomeOffsetsConsistently branch from 4d72284 to b2ff518 Compare October 11, 2020 13:55
@thinkyhead thinkyhead force-pushed the ApplyHomeOffsetsConsistently branch from c056c42 to 29e0edd Compare October 17, 2020 01:33
@thinkyhead thinkyhead force-pushed the ApplyHomeOffsetsConsistently branch from 29e0edd to 7b0d6a2 Compare October 17, 2020 01:34
@thinkyhead thinkyhead force-pushed the ApplyHomeOffsetsConsistently branch from 8adc6d6 to ae72a8b Compare October 17, 2020 01:51
@thinkyhead thinkyhead merged commit 6375829 into MarlinFirmware:bugfix-2.0.x Oct 18, 2020
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Oct 21, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Oct 23, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Nov 2, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
tharts pushed a commit to tharts/Marlin that referenced this pull request Jan 6, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
@InsanityAutomation InsanityAutomation deleted the ApplyHomeOffsetsConsistently branch April 3, 2021 15:22
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda pushed a commit to chrisjenda/Marlin that referenced this pull request Apr 8, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
chrisjenda pushed a commit to chrisjenda/Marlin that referenced this pull request Apr 11, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 28, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead added a commit that referenced this pull request Apr 30, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants