Add noise uncorrelation (data pre-whitening) before the reconstruction #140
Conversation
Laura2305
commented
Jan 25, 2023
Laura2305
commented
- Related to discussion SNR optimised reconstruction with noise matrix #135
- Noise pre-whitening added in reconstruction_multiCoil
Codecov ReportBase: 63.05% // Head: 65.67% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 63.05% 65.67% +2.61%
==========================================
Files 8 9 +1
Lines 249 268 +19
==========================================
+ Hits 157 176 +19
Misses 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Great work! I've incorporated a few suggestions in my review. I think there is a question whether we should change the output of setupIterativeReco and the input arguments of reconstruction_multiCoil to accommodate the passing of L_inv or whether we should pass L_inv as part of the recoParams struct. Perhaps @tknopp can weigh in on this.
test/testReconstruction.jl
Outdated
| params[:reco] = "multiCoil" #"standard" | ||
| params[:reconSize] = (N,N) | ||
| params[:regularization] = "L2" | ||
| params[:iterations] = 100 |
There was a problem hiding this comment.
Perhaps we should choose a smaller number of iterations (~20)
There was a problem hiding this comment.
20 iterations are not enough to reach the solution, when I use 20 I can still see ghosting artefacts. I tried with 100 and the artefacts are still there, after the noise decorrelation. With 150 I get the desired result.
Co-authored-by: Jeff Fessler <JeffFessler@users.noreply.github.com>
|
This PR looks very good, thank you @Laura2305. I would merge this if there are no objections. |
|
You're welcome. I'll have time to implement the raw data pre-whitening for the multi-coil, multi-echo reconstruction next week. I can open a new PR for that, or we can keep this one open for a few more days, as you prefer. |
|
Let's merge this. The multi-echo case can be implemented later. I gave you access rights so that you can also work on branches within this repository. This is often easier than to use a fork. |
