Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

不会加载文件名与已注册插件名称相同的插件 #510

Closed
Yushu2606 opened this issue Jul 9, 2022 · 3 comments
Closed

不会加载文件名与已注册插件名称相同的插件 #510

Yushu2606 opened this issue Jul 9, 2022 · 3 comments
Labels
bug Related to software malfunction

Comments

@Yushu2606
Copy link

Yushu2606 commented Jul 9, 2022 •
edited
Loading

异常模块

ScriptEngine(脚本引擎)

操作系统

Windows Server 2022

LiteLoader版本

2.3.2

BDS版本

1.19.2.02

发生了什么?

不会加载文件名与已注册插件名称相同的插件

复现此问题的步骤

  1. 添加注册为test的插件
  2. 添加插件test.js
  3. test.js被跳过

有关的日志/输出

No response

插件列表

No response
@Yushu2606 Yushu2606 added the bug Related to software malfunction label Jul 9, 2022
@github-actions github-actions bot added the status: review needed Requires assessment or evaluation label Jul 9, 2022
@Yushu2606 Yushu2606 changed the title 不会加载与已加载插件相同文件名但后缀不同的插件 不会加载文件名与已加载注册插件名称相同的插件 Jul 9, 2022
@Yushu2606 Yushu2606 changed the title 不会加载文件名与已加载注册插件名称相同的插件 不会加载文件名与已注册插件名称相同的插件 Jul 9, 2022
@Jasonzyt
Copy link
Member

Jasonzyt commented Jul 10, 2022 •
edited
Loading

原因应该是这
/~https://github.com/LiteLDev/LiteLoaderBDS/blob/929b78d3ea7222fb8878a0cb6229f3df817ba174/ScriptEngine/PluginManager.cpp#L87
不清楚是不是特别设计的 先放一放吧 感觉不会有特别大影响

@github-actions github-actions bot added status: on hold Temporarily paused or delayed and removed status: review needed Requires assessment or evaluation labels Jul 10, 2022
@Jasonzyt Jasonzyt assigned Jasonzyt and unassigned Jasonzyt Jul 10, 2022
@Yushu2606
Copy link
Author

原因应该是这

/~https://github.com/LiteLDev/LiteLoaderBDS/blob/929b78d3ea7222fb8878a0cb6229f3df817ba174/ScriptEngine/PluginManager.cpp#L87

不清楚是不是特别设计的 先放一放吧 感觉不会有特别大影响

这里的pluginFileName只有文件名，但注册时会带有后缀

@github-actions github-actions bot added status: review needed Requires assessment or evaluation and removed status: on hold Temporarily paused or delayed labels Jul 10, 2022
@Jasonzyt
Copy link
Member

/~https://github.com/LiteLDev/LiteLoaderBDS/blob/df836910c6c9b4728ecae727c89dc27b7e113a50/LiteLoader/Main/PluginManager.cpp#L97
在这里

@github-actions github-actions bot added status: on hold Temporarily paused or delayed and removed status: review needed Requires assessment or evaluation labels Jul 12, 2022
Jasonzyt added a commit that referenced this issue Jul 12, 2022
@Jasonzyt
Fix #510
4c774e5 
Fix warning C4715
@github-actions github-actions bot removed the status: on hold Temporarily paused or delayed label Jul 12, 2022
@Yushu2606 Yushu2606 mentioned this issue Oct 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Related to software malfunction
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jasonzyt @Yushu2606