-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Improved Item Opening Method Options #292
Conversation
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 3f35f99 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/617333efe5870d00070687e2 😎 Browse the preview: https://deploy-preview-292--dashy-dev.netlify.app |
Hi Lissy93! Thank you for contributing to Dashy! ✨ When making changes to the documentation, be sure to double check that:
Don't forget to verify they the config validator script responds correctly to your new attribute.
|
This pull request is split into 3 parts for easier review. Changed files are located in these folders:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed working with no regressions.
Size Change: +1.3 kB (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
…w supported opening methods
The fix for this issue has now been released in Dashy 1.9.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
Category: Feature
Overview
_top
and_parent
anchor targets on itemsappConfig.defaultOpeningMethod
option to specify default targetIssue Number #289
New Vars
appConfig.defaultOpeningMethod
enum
target
is specified for a given item. Can be eithernewtab
,sametab
,top
,parent
,modal
orworkspace
. Defaults tonewtab
item.target
enum
newtab
,sametab
,top
,parent
,modal
orworkspace
.The list of options for target/ default opening method are:
sametab
- The app will be launched in the current tabnewtab
- The app will be launched in a new tabmodal
- Launch app in a resizable/ movable popup modal on the current pageworkspace
- Changes to Workspace view, and launches apptop
- Opens in the top-most browsing context, useful if your accessing Dashy through an iframeScreenshot N/A
Code Quality Checklist (Please complete)