fine-tuned inclusion of target node ids if target node is not part of AMps2LionWebConverter #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AMps2LionWebConverter
dslmeinte
requested changes
Jan 11, 2024
| @@ -72,6 +72,25 @@ closure:: | |||
| Converts the listed nodes, all descendants, and all referenced nodes. | |||
| We apply this strategy until we include all Annotation, Containment, and Reference targets. | |||
|
|
|||
|
|
|||
| .Inclusion of nodes and ids | |||
There was a problem hiding this comment.
I still find this hard to grok. A diagram might help, but I think that I should make an effort myself, then :)
There was a problem hiding this comment.
Removed the node, as it's not relevant in default settings.
I'd still happily receive a better explanation (-:
solutions/io.lionweb.mps.json/models/io.lionweb.mps.json.instance.mps2lionweb.mps
Outdated
Show resolved
Hide resolved
dslmeinte
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.