Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when Rust app is a workspace #204

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Fix when Rust app is a workspace #204

merged 7 commits into from
Jul 30, 2024

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Jul 25, 2024

No description provided.

@yogh333 yogh333 requested a review from lpascal-ledger July 25, 2024 06:28
@yogh333 yogh333 force-pushed the y333/manage_rust_workspace branch from 94c2e40 to 842683d Compare July 25, 2024 08:56
@yogh333 yogh333 requested a review from fbeutin-ledger July 29, 2024 08:38
tdejoigny-ledger
tdejoigny-ledger reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please provide an example where we have the issue ?

src/ragger/utils/misc.py Outdated Show resolved Hide resolved
@yogh333 yogh333 requested a review from tdejoigny-ledger July 29, 2024 16:06
@yogh333 yogh333 force-pushed the y333/manage_rust_workspace branch from a18072b to ed60bf5 Compare July 30, 2024 09:39
lpascal-ledger
lpascal-ledger approved these changes Jul 30, 2024
View reviewed changes
tests/unit/utils/test_misc.py Outdated Show resolved Hide resolved
tests/unit/utils/test_misc.py Outdated Show resolved Hide resolved
lpascal-ledger
lpascal-ledger previously approved these changes Jul 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yogh333 yogh333 dismissed stale reviews from lpascal-ledger and tdejoigny-ledger via b2a8d83 July 30, 2024 13:03
lpascal-ledger
lpascal-ledger previously approved these changes Jul 30, 2024
View reviewed changes
lpascal-ledger
lpascal-ledger requested changes Jul 30, 2024
View reviewed changes
tests/unit/utils/test_misc.py Outdated Show resolved Hide resolved
@lpascal-ledger
Copy link
Contributor

lpascal-ledger commented Jul 30, 2024 •
edited
Loading

@yogh333 I did not see the CI was failing due to codespell, if you want to silence it you can modify the fast-checks.yml last line to be like ignore_words_list: assertIn,crate,

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yogh333 yogh333 requested a review from lpascal-ledger July 30, 2024 13:51
@yogh333 yogh333 merged commit 08914eb into master Jul 30, 2024
29 checks passed
@yogh333 yogh333 deleted the y333/manage_rust_workspace branch July 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpascal-ledger lpascal-ledger lpascal-ledger approved these changes

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

@tdejoigny-ledger tdejoigny-ledger Awaiting requested review from tdejoigny-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogh333 @lpascal-ledger @tdejoigny-ledger