Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a syscall to sign with endorsement key #466

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

srasoamiaramanana-ledger
Copy link
Contributor

@srasoamiaramanana-ledger srasoamiaramanana-ledger commented Nov 20, 2023

Description

This PR adds the syscall os_endorsement_key1_sign_without_code_hash that signs data with the endorsement key without adding the application's code hash to the data to sign.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

New syscall.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (033ef9f) 59.47% compared to head (6357c14) 59.47%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   59.47%   59.47%           
=======================================
  Files          12       12           
  Lines        1683     1683           
=======================================
  Hits         1001     1001           
  Misses        682      682           
Flag Coverage Δ
unittests 59.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srasoamiaramanana-ledger srasoamiaramanana-ledger force-pushed the endorsement_sign_without_code_hash branch 2 times, most recently from 8e5fbb3 to 6357c14 Compare November 23, 2023 14:09
@srasoamiaramanana-ledger srasoamiaramanana-ledger force-pushed the endorsement_sign_without_code_hash branch from 6357c14 to 9c3475d Compare November 29, 2023 13:29
@srasoamiaramanana-ledger srasoamiaramanana-ledger merged commit 4d0b5a7 into master Nov 29, 2023
160 checks passed
@srasoamiaramanana-ledger srasoamiaramanana-ledger deleted the endorsement_sign_without_code_hash branch November 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants