This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LIVE-2119 Bugfix/graph out of bound issue #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e values in svg in certain cases where the data domain values were too split in Y axis
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, Why /upgrade-llc ?If your PR requires an update to the ledger-live-common library, |
thomasrogerlux
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in graphs when values could be out of range due to too big of a difference between min and max Y axis values.
d3 lib would then try to create an svg area targeting out of bounds points.
A simple switch in the min value to target for the gradient area clears that
Type
Bug Fix
Context
LIVE-2119
Parts of the app affected / Test plan