♻️ (core) [DSDK-337]: Command signature: pass params to command constructor #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
-107
to
-115
| it("should not parse the response when getApdu not called", () => { | ||
| const PERCENTAGE_RESPONSE = new ApduResponse({ | ||
| statusCode: PERCENTAGE_RESPONSE_HEX.slice(-2), | ||
| data: PERCENTAGE_RESPONSE_HEX.slice(0, -2), | ||
| }); | ||
| expect(() => command.parseResponse(PERCENTAGE_RESPONSE)).toThrow( | ||
| InvalidBatteryStatusTypeError, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
this test was solely needed because there was no constructor initialising the arguments, so if getApdu(params) wasn't called) then some internal prop was not initialised.
aussedatlo
reviewed
Jun 12, 2024
| @@ -10,6 +10,8 @@ import { ApduResponse } from "@api/device-session/ApduResponse"; | |||
| * The command to close a runnint application on the device. | |||
| */ | |||
| export class CloseAppCommand implements Command<void> { | |||
| args: void = undefined; | |||
There was a problem hiding this comment.
[ASK] why specifying void here but not in the other commands ?
There was a problem hiding this comment.
ah it's a mistake, I was trying out different stuff and forgot to remove this
ofreyssinet-ledger
force-pushed
the
refacto/dsdk-337-command-params
branch
from
4c4d93f to
e3e9065
Compare
valpinkman
approved these changes
Jun 12, 2024
| @@ -10,6 +10,8 @@ import { ApduResponse } from "@api/device-session/ApduResponse"; | |||
| * The command to close a runnint application on the device. | |||
| */ | |||
| export class CloseAppCommand implements Command<void> { | |||
| args = undefined; | |||
| @@ -28,6 +28,8 @@ export type GetAppAndVersionResponse = { | |||
| export class GetAppAndVersionCommand | |||
| implements Command<GetAppAndVersionResponse> | |||
| { | |||
| args = undefined; | |||
| @@ -64,6 +64,8 @@ export type GetOsVersionResponse = { | |||
| * Command to get information about the device firmware. | |||
| */ | |||
| export class GetOsVersionCommand implements Command<GetOsVersionResponse> { | |||
| args = undefined; | |||
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Instead of doing
change to
The reasoning is that parameters are part of a command itself, not something living next to it.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers