Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (signer-eth) [DSDK-649]: Add PKI support with generic parser #645

Merged
merged 6 commits into from
Jan 30, 2025
Merged

✨ (signer-eth) [DSDK-649]: Add PKI support with generic parser #645

merged 6 commits into from
Jan 30, 2025

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Jan 29, 2025 •
edited by jira bot
Loading

📝 Description

To be able to clear sign transactions using prod signatures, qe need to provide some certificates to validate the data sent to the device.

  • Add a LoadCertificateCommand in dmk
  • Retrieve certificates from the CAL service and provide them through ContextSuccess to the signer
  • Send the certificate to the device if available

❓ Context

  • JIRA or GitHub link:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@aussedatlo aussedatlo requested a review from a team as a code owner January 29, 2025 14:13
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 8:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 8:34am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against dfd0e12

@aussedatlo aussedatlo changed the title ✨ (signer-eth) [DSDK-649]: Add PKI support for generic parser context ✨ (signer-eth) [DSDK-649]: Add PKI support with generic parser Jan 29, 2025
aussedatlo
aussedatlo commented Jan 29, 2025
View reviewed changes
.changeset/thirty-adults-beg.md
@@ -0,0 +1,5 @@
---
"@ledgerhq/context-module": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ASK] could be major since we changed the TransactionContext type from the context-module

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't break anything as it's just adding so minor is still OK in my opinion

@aussedatlo aussedatlo force-pushed the feat/dsdk-649-generic-parser-pki-support branch from 099daf0 to 954965b Compare January 29, 2025 16:31
mbertin-ledger
mbertin-ledger approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mbertin-ledger mbertin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

paoun-ledger
paoun-ledger approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@paoun-ledger paoun-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, missing from ProvideTransactionContext task but it's probably for a later ticket?

@aussedatlo aussedatlo force-pushed the feat/dsdk-649-generic-parser-pki-support branch from 954965b to dfd0e12 Compare January 30, 2025 08:32
@aussedatlo aussedatlo added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 8e8a66a Jan 30, 2025
12 checks passed
@aussedatlo aussedatlo deleted the feat/dsdk-649-generic-parser-pki-support branch January 30, 2025 09:14
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbertin-ledger mbertin-ledger mbertin-ledger approved these changes

@paoun-ledger paoun-ledger paoun-ledger approved these changes

Assignees

@aussedatlo aussedatlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aussedatlo @mbertin-ledger @paoun-ledger