Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 (signer-eth) [DSDK-639]: Use clear signing with Nano S #609

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Jan 14, 2025

📝 Description

Nano S does not support getChallenge command, but can clear sign basic operations such as ERC20 transfert or plugins.
So we need to be able to provide non generic-parser context to the device if the command is failing.

For the sign transaction:

  • If we have a Nano S, get challenge return an error, we skip it.
  • The build context task will not return a domain context as the challenge is not provided
  • The provide context task will be called as the Nano S does not support generic parser.
  • The signTransaction task is called and data is displayed on the screen.

Also, this PR provide the deviceModelId to the DeviceSession as we need to handle the signTransaction differently for the Nano S

❓ Context

  • JIRA or GitHub link: [DSDK-639]
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Nano S does not support getChallenge command, but can clear sign basic operations such as ERC20 transfert or plugins.
So we need to be able to provide non generic-parser context to the device if the command is failing.
@aussedatlo aussedatlo requested a review from a team as a code owner January 14, 2025 13:01
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 1:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Jan 14, 2025 1:02pm

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Messages
Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 5aaf664

@aussedatlo aussedatlo added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit 1efd75b Jan 17, 2025
13 checks passed
@aussedatlo aussedatlo deleted the feat/dsdk-639-nano-s-clear-signing branch January 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants