✨ (context-module) [DSDK-516]: Use descriptors_eip712 instead of eip712_signatures #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aussedatlo
force-pushed
the
feat/dsdk-516-new-cal-object
branch
from
ec25a32 to
14068b6
Compare
mbertin-ledger
approved these changes
Oct 7, 2024
paoun-ledger
reviewed
Oct 7, 2024
paoun-ledger
reviewed
Oct 7, 2024
packages/signer/context-module/src/typed-data/data/FiltersDto.ts
Outdated
Show resolved
Hide resolved
paoun-ledger
reviewed
Oct 7, 2024
packages/signer/context-module/src/typed-data/data/FiltersDto.ts
Outdated
Show resolved
Hide resolved
aussedatlo
force-pushed
the
feat/dsdk-516-new-cal-object
branch
from
de15908 to
f1c5f85
Compare
aussedatlo
force-pushed
the
feat/dsdk-516-new-cal-object
branch
from
f1c5f85 to
979c18c
Compare
paoun-ledger
reviewed
Oct 7, 2024
| | InstructionFieldV1 | ||
| | InstructionFieldV2 | ||
| | InstructionFieldV2WithCoinRef | ||
| | InstructionFieldWithContractInfo; |
There was a problem hiding this comment.
maybe just InstructionContractInfo since it's not a field?
paoun-ledger
reviewed
Oct 7, 2024
| field_mappers_count?: never; | ||
| field_path: string; | ||
| signatures: InstructionFieldSignatures; | ||
| type: "field" | "message"; |
There was a problem hiding this comment.
only field here (same for InstructionFieldV2)
There was a problem hiding this comment.
We can get a message type with the current CAL version 🤔
aussedatlo
force-pushed
the
feat/dsdk-516-new-cal-object
branch
from
979c18c to
296b51a
Compare
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Use
descriptors_eip712instead ofeip712_signatureswhile fetching data from the CAL service.❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers