split the defined_unit_string into a customary and si blocks #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st step to being able to partition the entire system in a strict SI vs all unit parser/generator. There will be a number of other steps before that point.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
==========================================
+ Coverage 97.56% 97.58% +0.02%
==========================================
Files 10 10
Lines 4597 4600 +3
==========================================
+ Hits 4485 4489 +4
+ Misses 112 111 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a first step to being able to partition the entire system in a strict SI vs all unit parser/generator. There will be a number of other steps before that point.
The next step will be to do something similar for the other direction including tests of the vector itself.
This PR splits the definitions into two components and removes a few duplicates and 1 overwritten symbol
Namely "D" for day was being interpreted as "Debye" (the cgs unit of electrical dipole moment) which is probably not that common.